Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address warnings #292

Merged
merged 15 commits into from
Jan 30, 2024
Merged

Address warnings #292

merged 15 commits into from
Jan 30, 2024

Conversation

sjperkins
Copy link
Member

  • Tests added / passed

    $ py.test -v -s africanus

    If the pre-commit tests fail, install and
    run the pre-commit hooks in your development
    virtuale environment:

    $ pip install pre-commit
$ pre-commit install
$ pre-commit run -a

  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
cd docs
READTHEDOCS=True make html

@sjperkins
Use np.prod, np.product is deprecated in numpy 1.25
73ce157
@sjperkins
Create a .env file to supply environment variables to pip
078437f
@sjperkins
Fix specification of python-version
17250d0
@sjperkins
Use importlib.resources
12ab506
@sjperkins
fix .env creation, and temporarily disable complete test suite
dc3ef7e
@sjperkins
Handle deprecated collect_ignore
e1d4adb
@sjperkins
escape env vars
78cfd9b
@sjperkins
Temporarily disable .env file creation
afc2fab
@sjperkins
Reintroduce prefer_literal=True which is required to get the desired …
d541e67 
…behaviour with new style numba errors
@sjperkins
Re-enable .env file
9e5bca1
@sjperkins
Re-enable complete test suite
bed2d4a
@sjperkins
Remove pyyaml from the install
c620324
@sjperkins
Separate basis_function into real and complex implementations to avoi…
21edff5 
…d complex to real conversion warnings
@sjperkins
Add prefer_literal=True to @Overloads in the Perley Polyhedron gridder
8155867
@sjperkins
[skip ci] Update HISTORY.rst
71a0808
@sjperkins sjperkins merged commit 034b3ce into master Jan 30, 2024
@sjperkins sjperkins deleted the address-warnings branch January 30, 2024 14:54
sjperkins
sjperkins commented Jan 31, 2024
View reviewed changes
africanus/gridding/perleypolyhedron/policies/stokes_conversion_policies.py
@@ -5,7 +5,7 @@ def stokes2corr(vis_in, vis_out, policy_type):
pass


@overload(stokes2corr, inline="always")
@overload(stokes2corr, inline="always", prefer_literal=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bennahugo Just letting you know that the test cases you wrote easily highlighted up the above needed change, due to the following https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-old-style-numba-captured-errors.

So the test cases were useful to have and I didn't have to understand the implementation to do the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjperkins